06:30 <lawl> hey, i patched the xpad driver for xbox controllers on my machine to fix an annoyance and wanted to apply it on my libreelec box. normally i would to that by building it with dkms, but libreelec doesn't have that. what's the recommended way to test a patched kernel module on libreelec, preferrably without building it from scratch?

07:07 <chewitt> lawl kinda hard due to the way LE packages everything into two files

07:07 <chewitt> in theory you 'only' need to build the target kernel

07:08 <chewitt> but that already builds a fair chunk of the image, so really you might as well build the whole thing

07:10 <chewitt> in terms of how you add the patch

07:10 <lawl> yeah i just tried grabbing the matching kernel source from kernel.org and just building the module with make M=drivers/.... and see if i can just dump the built `.ko` on the libreelec system and load it with `insmod`. We'll see if that works i guess

07:10 <chewitt> create a diff patch and place in packages/linux/patches/

07:39 <lawl> nope, can't get it to load correctly, it said it's loaded, but doesn't work :/

07:56 <chewitt> time to build the full image then

07:56 <lawl> i could also just try to upstream it and wait

07:57 <lawl> i'm really lazy :P

07:57 <chewitt> which device do you need to test it on

07:57 <chewitt> ?

07:58 <lawl> x64 chromebox, so i wouldn't need to cross compile, i'll probably do it the next couple of days. maybe libreelec would even take the patch before i try upstreaming it into the kernel, not sure if they'll accept it

07:59 <chewitt> well, now you revealed the patch is untested, we (me) won't be blind merging it :)

07:59 <lawl> it's not untested, it's tested on my regular linux box

08:00 <lawl> and before sending it to libreelec, yes, i would of course test it there too

08:01 <chewitt> can you share the patch?

08:01 <chewitt> i.e. pastebin it

08:02 <lawl> sure: https://gist.github.com/lawl/cd21cd92ae05483456be83522f92ad30

08:02 <lawl> adds the ability to turn off xbox 360 wireless controllers, which you currently can only do by popping the battery pack, which is annoying

08:05 <chewitt> the other criteria for accepting patches is normally that the patch has been submitted upstream, so we can later drop the patch

08:06 <chewitt> else we end up hoarding stuff for years, and it gets messy (a lesson learned the hard way)

08:07 <lawl> yeah i'll probably try to upstream it, just not sure if they'll accept it. there's an argument to be made that this is something userspace should handle

08:08 <lawl> though, currently userspace has no interface to actually do that, so i just wanted to patch to driver and pop the patched driver in as a dkms module on libreelec, but as i just learned, that won't work, so...

08:15 <chewitt> I started a build running with the patch .. should be done in about 30-35 mins

08:16 <lawl> oh, awesome, thanks

08:16 <chewitt> re. upstreaming .. nothing ventured, nothing gained

08:17 <chewitt> i'm always happy to pre-review patches for etiquette mistakes if you put the commit in a public repo I can look at

08:18 <lawl> haha yeah, but the LKML is scary and i'm neither a C hacker a kernel hacker nor do I like e-mail very much

08:18 <chewitt> I can't review code, but it's usually the process stuff that trips people up

08:19 <chewitt> e.g. use of real names, typo's, factual titles and info in the submission, etc.

08:19 <lawl> yes. and e-mail. i hate e-mail

08:20 <chewitt> but "it is the way" so gotta roll with it

08:20 <chewitt> once you setup git with some aliases it's a lot easier

09:16 <chewitt> lawl https://chewitt.libreelec.tv/testing/9.80/LibreELEC-Generic.x86_64-9.80.7.tar

09:16 <chewitt> ignore the funny versioning..

09:24 <lawl> awesome, ty, flashing it now

09:29 <lawl> no dice, unfortunately

09:39 <lawl> kicked off my own build, let's see

12:24 <yang> Will there eventually be LE support for Chromebox 4, which gets on market in december?

12:40 <lawl> chewitt: finished building and tested it now, and it works, so i'm happy, thanks for your help! i think something must have gone wrong applying the patch before.

21:43 <tommygunner> hi

21:43 <tommygunner> there are some wrong checksums, causing some errors when running the download-tool

21:43 <tommygunner> LibreELEC.tv/sources/libretro-mame2016/libretro-mame2016-02987af9b81a9c3294af8fb9d5a34f9826a2cf4d.tar.gz' saved [114715427]

21:43 <tommygunner> WARNING Incorrect checksum calculated on downloaded file: got 4bd7e13d94506f6f556ddc3615b230645d72114f377cb84297dfd284372a4c5b wanted d09ce628901f8b19417f05a84aa7cb1bc2b567b05b0de2bb425451d62f897507