proteusguy has quit [Remote host closed the connection]
proteusguy has joined #symbiflow
<sf-slack2>
<arora.prayas> Hi @channel, I changed the vtr source code to fix two build warnings. I want to create a pull request for the same. While adding description for it, I saw that there should be an issue against the changes I propose. Do I file an issue first that can be reproduced to verify my changes ?
<sf-slack2>
<kgugala> Hi @arora.prayas please open an issue where you describe the problem and then create PR where you link to the issue
<sf-slack2>
<arora.prayas> Okay, thanks :)
futarisIRCcloud has quit [Quit: Connection closed for inactivity]
futarisIRCcloud has joined #symbiflow
Bertl_zZ is now known as Bertl
OmniMancer has quit [Quit: Leaving.]
_whitelogger has joined #symbiflow
futarisIRCcloud has quit [Quit: Connection closed for inactivity]
<sf-slack2>
<arora.prayas> I fixed the first two warnings(haven't created a pull request yet). The last warning for possibly dereferencing a null pointer is giving me a hard time. I tried various ways but haven't been able to get around it. One interesting thing to note is that there is no warning message for: _if (child_pbs != nullptr && has_modes())_ but, return child_pbs == nullptr; //or if(child_pbs != nullptr) give a warning:
<sf-slack2>
<arora.prayas> I am not trying to fixate on warning issues, neither do I want to waste anybody's time. But generally, any tool should build without any warnings in favour of the user. Often at building time, all warnings are treated as errors.
<sf-slack2>
<arora.prayas> Any help would be appreciated :slightly_smiling_face: