13:02 <sf-slack2> <arora.prayas> Hi, After merging of a PR, should the merger close the corresponding issue or the person raising PR ?

13:53 <hackerfoo> I'd say whoever verifies that the issue has been fixed, ideally by adding a test. Usually the author of the PR.

13:59 <sf-slack2> <arora.prayas> Alright, thanks

14:49 <sf-slack2> <mkurc> Good time of day! I've decided to change my approach to the CLB split a little. I created a document which summarizes the changes: https://docs.google.com/document/d/1jk99M118j4ByM3Z9MbretvR2Nwh9Vx1b22H2w0WaHyY

14:49 <tpb> Title: Google Docs - create and edit documents online, for free. (at docs.google.com)

15:12 <mithro> Morning!

15:12 <mithro> kgugala / acomodi: Can I get you to review https://github.com/SymbiFlow/symbiflow-arch-defs/pull/613 so I can land it?

15:12 <tpb> Title: Move the type information from the names into metadata. by mithro · Pull Request #613 · SymbiFlow/symbiflow-arch-defs · GitHub (at github.com)

15:13 <mithro> It seems to pass CI

15:13 <mithro> But seeing as how large it is, I would like to land it ASAP

15:15 <sf-slack2> <acomodi> Morning

15:16 <sf-slack2> <acomodi> mithro: Ok, I'm on it

15:17 <mithro> acomodi: Thanks!

15:58 <mithro> FYI - I also started putting together https://docs.google.com/document/d/1ngck6LGVTXm6HDrVqWeEGdEELrKPWXVaeejkXurgfl4/edit#

15:58 <tpb> Title: SymbiFlow Parts Encyclopedia - Google Docs (at docs.google.com)

16:20 <sf-slack2> <kgugala> pyosys has been merged into upstream's Yosys https://github.com/YosysHQ/yosys/commit/99d5435650c38fb96dc364c0fd4ac6250a4871ea

16:20 <tpb> Title: Merge pull request #905 from christian-krieg/feature/python_bindings · YosysHQ/yosys@99d5435 · GitHub (at github.com)

16:43 <mithro> kgugala: Yeah - it lets you write passes (for things like optimization, checking, transforms) in Python

17:37 <mithro> kgugala: Don't know what is up with kokoro at the moment...

17:48 <mithro> kgugala: Looks like kokoro is broken at the moment...

17:54 <mithro> elms: all_icestick_bin should be enough to make sure that ice40 is working, right?

17:56 <mithro> kgugala: Are you going to work on the v2x tests now, or should I work on that after landing #613?

17:56 <sf-slack2> <kgugala> I can take a look on those

17:58 <elms> That should make sure you can still generate bitstreams. It should cover a lot of concerns. To get better coverage we are going to have to work on HIL (Hardware in the loop) testing

17:58 <elms> mithro: ^

17:59 <mithro> elms: Yeah

17:59 <mithro> kgugala: I more mean that I will look at them potentially in a couple of hours, I can hand them over to you when you get up tomorrow?

18:01 <sf-slack2> <kgugala> sure, let's do like that then

18:02 <sf-slack2> <kgugala> just assign the issue to me, and I'll take it from there

21:05 <mithro> kgugala / elms: I merged the prefix removal pull request

21:05 <elms> mithro: thanks for the heads up

21:15 <mithro> elms: Do you know how I run the tests under `utils/vlog`?

21:16 <elms> mithro: let me look

21:19 <elms> mithro: I think remove the lines from https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/utils/conftest.py

21:19 <tpb> Title: symbiflow-arch-defs/conftest.py at master · SymbiFlow/symbiflow-arch-defs · GitHub (at github.com)

21:20 <mithro> elms: How do I run the tests however? What is the make target?

21:21 <elms> `make test_python_utils` trying now

21:23 <elms> mithro: yep works from my build directory

21:23 <mithro> elms: That seems to just run the Python tests, not the diff ones?

21:24 <elms> what diff tests?

21:24 <mithro> https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/utils/vlog/CMakeLists.txt

21:24 <tpb> Title: symbiflow-arch-defs/CMakeLists.txt at master · SymbiFlow/symbiflow-arch-defs · GitHub (at github.com)

21:27 <elms> ahh I was on an older fork. Looks like if you uncomment that then `make all_v2x_tests`

21:30 <mithro> elms: Also -> https://github.com/SymbiFlow/symbiflow-arch-defs/issues/626

21:30 <tpb> Title: Clean up the top level directory · Issue #626 · SymbiFlow/symbiflow-arch-defs · GitHub (at github.com)