d_n|a has quit [Read error: Connection reset by peer]
d_n|a has joined #m-labs
<adamgreig>
huh, tiresome. the memory fails to simulate if it only has a read port and no write port
<adamgreig>
ah, I guess the memory._array doesn't survive into the final fragment unless a write_port is put into submodules, at which point mem.py L177 causes it to get associated with the write port
<adamgreig>
no unit tests for read-only memories :p
<adamgreig>
no, that explanation doesn't quite make sense, since the read_port also contains statements accessing the parent _array
_whitenotifier-e has joined #m-labs
<_whitenotifier-e>
[nmigen] adamgreig opened issue #20: Memory with only a read port fails in pysim - https://git.io/fh33D
<GitHub-m-labs>
[artiq] sbourdeauducq commented on issue #1185: > Also, @sbourdeauducq never said what should happen in the above comments. A statement of a docstring being "obvious" or "redundant" is not saying that it should be removed... https://github.com/m-labs/artiq/pull/1185#issuecomment-451620658
<GitHub-m-labs>
[artiq] sbourdeauducq commented on pull request #1185 a3711a4: No error message is fine since users are never supposed to see this error. This is only to give a hint to the developer. https://github.com/m-labs/artiq/pull/1185#discussion_r245463359
<GitHub-m-labs>
[artiq] sbourdeauducq commented on issue #1188: > My understanding is that this is due to the nature of ARTIQ. ARTIQ has received contributions from people with varying levels of programming experience, who might be unaware that type annotations exist.... https://github.com/m-labs/artiq/pull/1188#issuecomment-451621126
<GitHub-m-labs>
[artiq] sbourdeauducq commented on issue #1185: > The docstrings that @sbourdeauducq called out above are recommended by `pydocstyle` because they are publicly available functions and so should be documented.... https://github.com/m-labs/artiq/pull/1185#issuecomment-451621390
<bb-m-labs>
build #2784 of artiq is complete: Failure [failed python_unittest_2] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/2784 blamelist: Drew <drewrisinger@users.noreply.github.com>
<GitHub-m-labs>
[artiq] sbourdeauducq commented on issue #1188: > This is one of the main benefits. Type annotations can be statically checked to catch obvious mistakes (e.g. `mypy`), while still being optional.... https://github.com/m-labs/artiq/pull/1188#issuecomment-451623296
<bb-m-labs>
build #2184 of artiq-board is complete: Failure [failed conda_build] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/2184 blamelist: Drew <drewrisinger@users.noreply.github.com>, Drew Risinger <drewrisinger@users.noreply.github.com>
<bb-m-labs>
build #2785 of artiq is complete: Failure [failed] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/2785 blamelist: Drew <drewrisinger@users.noreply.github.com>, Drew Risinger <drewrisinger@users.noreply.github.com>