Guest42597 has quit [Killed (weber.freenode.net (Nickname regained by services))]
dconroy has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
vindelschtuffen has quit [Ping timeout: 246 seconds]
asyncsec has joined #ipfs
domanic has quit [Quit: Konversation terminated!]
vindelschtuffen has joined #ipfs
vindelschtuffen has quit [Ping timeout: 258 seconds]
palkeo has quit [Ping timeout: 240 seconds]
jkilpatr has quit [Ping timeout: 246 seconds]
vindelschtuffen has joined #ipfs
vindelschtuffen has quit [Ping timeout: 240 seconds]
dconroy has joined #ipfs
dimitarvp has quit [Read error: Connection reset by peer]
jaboja has quit [Ping timeout: 240 seconds]
_whitelogger has joined #ipfs
chris613 has quit [Quit: Leaving.]
Miezel has joined #ipfs
jsgrant has quit [Quit: Peace Peeps. o/ If you need me asap, message me at msg([at])jsgrant.io & I'll try to get back to you within 24-36 hours.]
bedeho has joined #ipfs
McJuicy has joined #ipfs
robattila256 has quit [Quit: WeeChat 1.8]
bedeho has quit [Ping timeout: 240 seconds]
vindelschtuffen has joined #ipfs
webdev007 has joined #ipfs
chris613 has joined #ipfs
McJuicy has quit [Quit: Pce]
robattila256 has joined #ipfs
stoopkid has joined #ipfs
jaboja has joined #ipfs
shizy has joined #ipfs
webdev007 has quit [Ping timeout: 268 seconds]
shizy has quit [Ping timeout: 240 seconds]
dconroy has quit [Read error: Connection reset by peer]
clemo has quit [Ping timeout: 240 seconds]
asyncsec has quit [Quit: asyncsec]
rudolph has joined #ipfs
anewuser has quit [Ping timeout: 240 seconds]
anewuser has joined #ipfs
Mateon3 has joined #ipfs
Mateon1 has quit [Ping timeout: 240 seconds]
Mateon3 is now known as Mateon1
Miezel has quit [Quit: This computer has gone to sleep]
Miezel has joined #ipfs
Miezel has quit [Client Quit]
bedeho has joined #ipfs
webdev007 has joined #ipfs
McJuicy has joined #ipfs
McJuicy has quit [Ping timeout: 246 seconds]
owlet has quit [Ping timeout: 240 seconds]
palkeo has joined #ipfs
palkeo has joined #ipfs
palkeo has quit [Changing host]
zuck05 has quit [Ping timeout: 240 seconds]
zuck05 has joined #ipfs
chris613 has quit [Quit: Leaving.]
anewuser has quit [Quit: anewuser]
webdev007 has quit [Ping timeout: 255 seconds]
jsgrant has joined #ipfs
<jamesstanley>
can anyone explain why --enable-gc is off by default?
<jamesstanley>
from my reading of the code, no gc happens at all except when you run "ipfs repo gc", or when --enable-gc is on
jsgrant has quit [Ping timeout: 246 seconds]
o33 has joined #ipfs
jaboja has quit [Ping timeout: 268 seconds]
palkeo has quit [Ping timeout: 276 seconds]
<whyrusleeping>
jamesstanley: its mostly disabled because we havent been able to test it well
<whyrusleeping>
and because if gc randomly runs while youre doing something, you might lose objects youre working with, but havent gotten to pinning yet
<jamesstanley>
is it LRU?
<whyrusleeping>
no, its mark and sweep
<whyrusleeping>
so theres no 'ive recently used this, dont gc it please'
<whyrusleeping>
that would be nice to have though
<jamesstanley>
so the gc just deletes everything that's not pinned?
<jamesstanley>
my mental model was that it would work more like a browser cache: pinned content stays there, and then the most-recently-used content remains, counting until the 10G is used up, and everything over that gets deleted
<whyrusleeping>
yeap, gc deletes everything thats not pinned
<whyrusleeping>
the 10GB is when a GC is triggered to be run
<whyrusleeping>
and it deletes everything
<jamesstanley>
thanks
<whyrusleeping>
no concept of 'what is used most recently' is stored on disk
<whyrusleeping>
so we have no easy way to make that discernment
ulrichard has joined #ipfs
<whyrusleeping>
jamesstanley: if you want.... you could make GC better ;)
<jamesstanley>
I haven't even managed to get that writeable gateway change to pass tests yet :)
<whyrusleeping>
hrm... lemme go look at that one real quick
<jamesstanley>
I gave a talk on cryptocurrencies and ipfs at work the other day
<jamesstanley>
to ~20 people
<whyrusleeping>
jamesstanley: oh, i think you should just rebase that branch on the latest master and force push
<jamesstanley>
it was mostly cryptocurrencies, with just a bit on ipfs at the end, I don't think I did a good job of evangelising as I was rushing it, but they seemed basically interested
<whyrusleeping>
the issues i see in CI were random failures that weve fixed some of
<whyrusleeping>
jamesstanley: ah sweet!
<jamesstanley>
I saw you suggested that but I hadn't quite worked out the incantation
<whyrusleeping>
Thats always great to hear :)
<whyrusleeping>
git pull --rebase origin master
<whyrusleeping>
should do it
<jamesstanley>
cheers
<jamesstanley>
my repo is cloned from github.com/jes/ipfs
<jamesstanley>
go-ipfs, sorry
<jamesstanley>
so my origin is my repo on github, not the ipfs project one
<jamesstanley>
this is what I was struggling to work out
<jamesstanley>
I might just copy my changes into a file, then force update jes/go-ipfs to the current master on ipfs/go-ipfs, and then commit afresh
<jamesstanley>
nm, think I might have done it
<whyrusleeping>
ooooo
<whyrusleeping>
i would add the ipfs/go-ipfs one as a remote
<tomatopeel>
I might be being blind but I'm pretty sure nothing is actually done with this map? Oh hmmm, it is used in the parseFlag function actually.
<tomatopeel>
I guess maybe it's just to check if a flag is a valid one for a particular command
<tomatopeel>
okay yeah, nevermind, I get it
<tomatopeel>
I was just going through the cli parsing code with a run of "ipfs add whatever", I'll add a flag though and then I'm sure this will become clear
ulrichard has joined #ipfs
ghjbjgftr has joined #ipfs
ghjbjgftr has quit [Remote host closed the connection]
ghjbjgftr has joined #ipfs
jytfyjtf has quit [Ping timeout: 255 seconds]
brodo has quit [Ping timeout: 246 seconds]
brodo has joined #ipfs
[X-Scale] has joined #ipfs
X-Scale has quit [Ping timeout: 240 seconds]
[X-Scale] is now known as X-Scale
maxlath has quit [Ping timeout: 255 seconds]
DJHenk_ has quit [Quit: IRC for Sailfish 0.9]
brodo has quit [Ping timeout: 268 seconds]
brodo has joined #ipfs
brodo has quit [Ping timeout: 255 seconds]
brodo has joined #ipfs
kenshyx has joined #ipfs
citizenErased has joined #ipfs
xelra has quit [Remote host closed the connection]
jkilpatr has quit [Ping timeout: 255 seconds]
leeola has joined #ipfs
brodo has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
nunofmn has joined #ipfs
crankylinuxuser has joined #ipfs
jkilpatr has joined #ipfs
asyncsec has joined #ipfs
pat36 has quit [Read error: Connection reset by peer]
pat36 has joined #ipfs
joocain2 has quit [Remote host closed the connection]
joocain2 has joined #ipfs
owlet has joined #ipfs
bananabread[m] has joined #ipfs
nunofmn has quit [Ping timeout: 255 seconds]
nunofmn has joined #ipfs
brodo has joined #ipfs
nunofmn has quit [Client Quit]
robattila256 has joined #ipfs
owlet has quit [Ping timeout: 246 seconds]
tantalum has joined #ipfs
brodo has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
ashark has joined #ipfs
DJHenk has left #ipfs [#ipfs]
owlet has joined #ipfs
maxlath has joined #ipfs
webdev007 has joined #ipfs
brodo has joined #ipfs
shizy has joined #ipfs
ulrichard has quit [Remote host closed the connection]
robattila256 has quit [Quit: WeeChat 1.8]
jonnycrunch has quit [Ping timeout: 255 seconds]
jonnycrunch has joined #ipfs
Miezel has quit [Quit: This computer has gone to sleep]
m0ns00n has joined #ipfs
rjewing has joined #ipfs
Hasperov has joined #ipfs
Miezel has joined #ipfs
ylp1 has quit [Quit: Leaving.]
Hasperov has left #ipfs [#ipfs]
brodo has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
rudolph has joined #ipfs
m0ns00n has quit [Quit: quit]
Hasperov has joined #ipfs
leeola has quit [Quit: Connection closed for inactivity]
rjewing has quit [Quit: rjewing]
brodo has joined #ipfs
<sprint-helper7>
The next event "IPFS All Hands Call" is in 15 minutes.
Hasperov has quit [Ping timeout: 240 seconds]
JayCarpenter_ has joined #ipfs
brodo has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<tomatopeel>
jesus... i totally didn't realise how many of these decentralized storage projects there are that have popped up... sia, storj, maidsafe, golem....
nunofmn has joined #ipfs
<r0kk3rz>
dat, zeronet, morph.is ...
<francis[m]>
i have ipfs working on a rpi2 at the moment, but, my god, its making it sweat.
<whyrusleeping>
swarm
<whyrusleeping>
francis[m]: yeah, we really need to get connection closing figured out
<whyrusleeping>
tahts the biggest issue right now on resource consumption
<tomatopeel>
ipfs has by far the most contributors on github at least
<francis[m]>
avg at 35% cpu load
<Miezel_>
r0kk3rz: ok so what actually happens when a file is requested ? i was reading about wantlist being sent and shared file but i'm a tad bit confused
<francis[m]>
and 120meg of ram.. pfew
<r0kk3rz>
Miezel_: magic. the whitepaper is probably the best place to read about it
<tomatopeel>
whyrusleeping: I just read your reply above. You're refactoring the CLI commands code? feat/commands2.0? I've been staring hard at this code for a few days, was writing a blog post for my own benefit on how it actually works
<tomatopeel>
plan was to then do another blog post on how certain commands like add and the daemon and ipns actually work in code-walk terms
<whyrusleeping>
tomatopeel: yeah, keks[m] is working on that refactor
<whyrusleeping>
its quite close, hoping to get it merged for 0.4.11
<Miezel_>
r0kk3rz, alright, thanks i ll look that up
<tomatopeel>
cool, I'll take a look, maybe a good foot in the door to me to contribute, who knows
<whyrusleeping>
tomatopeel: yeah, its a big PR, beware
<keks[m]>
I rebased to master on the weekend
<keks[m]>
whyrusleeping: can you ping me when 0.4.10 get's released? I'm afraid I might miss it
<whyrusleeping>
keks[m]: today :)
<whyrusleeping>
i'm working on the final changelog now
<tomatopeel>
lol god dammit I spent like 2 days getting my head around the old CLI >.<
<keks[m]>
:D
<keks[m]>
alright!
<keks[m]>
I'll rebase again then, should be an easy merge afterwards
<whyrusleeping>
tomatopeel: the new stuff isnt completely alien
<whyrusleeping>
its more of a gradual shift towards a better way of architecting things
Encrypt has quit [Quit: Quit]
<whyrusleeping>
keks[m] can probably elaborate more if you have questions :)
<tomatopeel>
yeah I see this cmdkit and whatnot
<tomatopeel>
it's cool, I've gotten pretty used to dealing with all this Go now... got Delve working and Emacs godef-jump so it's quite nice...
nixze has quit [Read error: Connection reset by peer]
<francis[m]>
what should i expect to get with this command? ipfs ls
<francis[m]>
im getting ipfs: Reading from /dev/stdin; send Ctrl-d to stop.
<francis[m]>
??
mildred has quit [Ping timeout: 240 seconds]
rendar has quit [Ping timeout: 240 seconds]
<tomatopeel>
francis[m]: you should provide a hash to ls
<tomatopeel>
ipfs ls --help
Hasperov has joined #ipfs
<francis[m]>
ipfs ls <ipfs-path>... - List directory contents for Unix filesystem objects.
<francis[m]>
so, i will need to look what hashes i have...
<tomatopeel>
francis[m]: you can use ipfs pin
<tomatopeel>
or ipfs refs
<francis[m]>
i was looking for the hash to pin something, which i understand prevents it from getting deleted
<francis[m]>
ipfs refs: ipfs: Reading from /dev/stdin; send Ctrl-d to stop.
<francis[m]>
doesnt do anything
<tomatopeel>
keks[m]: whyrusleeping: the `ipfs pin --help` command is broken in commands2.0
<tomatopeel>
francis[m]: ipfs pin ls
<francis[m]>
ipfs refs local
<francis[m]>
gives me list of hashes, but how do i find that one local file thats on my machine
<francis[m]>
is a local file inmediately and automatically pinned?
<tomatopeel>
francis[m]: there is no file... there are blocks... :P
<tomatopeel>
yes
<tomatopeel>
by default
espadrine has quit [Ping timeout: 240 seconds]
<francis[m]>
ipfs pin ls doesnt give me anything, does it take a long time to complete?
<tomatopeel>
ah shit I guess `make install` doesn't compile stuff to play nicely with the debugger
<tomatopeel>
silly me
<whyrusleeping>
thats weird
<tomatopeel>
can I pass `make install` those ld/gc flags for debugging support?
<whyrusleeping>
you can also just run `go install ./cmd/ipfs`
<whyrusleeping>
make install is just a helper that makes sure dependencies have been installed
<tomatopeel>
don't those dependencies also need to be installed with the appropriate non-optimizing flags though?
<whyrusleeping>
you can just pass the '-a' flag to rebuild everything
<tomatopeel>
ah nice, ty
<tomatopeel>
gotta run home now anyway... wonder if I'll be able to beat keks[m] to iron this bug out... if you're busy with other stuff keks[m], I plan to take a look at it this evening and try to do a fix, I'm hungry to make a contribution to this kind of a project and I need this kind of thing because I plan to apply for jobs in this sector... I'm a noob right now though :P
nunofmn has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
nunofmn has joined #ipfs
nunofmn has quit [Client Quit]
nunofmn has joined #ipfs
nunofmn has quit [Client Quit]
seagreen has quit [Quit: WeeChat 1.7.1]
seagreen has joined #ipfs
nunofmn has joined #ipfs
nunofmn has quit [Client Quit]
nunofmn has joined #ipfs
nunofmn has quit [Client Quit]
<whyrusleeping>
tomatopeel: you might beat keks[m] simply because its quite late where he is right now
<francis[m]>
my last silly question for today.. how can list the hashes (files??) in ipfs
nunofmn has joined #ipfs
<whyrusleeping>
francis[m]: what do you mean?
nunofmn has quit [Client Quit]
<francis[m]>
is file=hash?
nunofmn has joined #ipfs
<francis[m]>
i added a file to ipfs yesterday, so, i want to find it again
nunofmn has quit [Client Quit]
nunofmn has joined #ipfs
<whyrusleeping>
ah, thats a little difficult to do right now because we don't track each add call the user makes
nunofmn has quit [Client Quit]
<whyrusleeping>
you can list pinned things with `ipfs pin ls`
<whyrusleeping>
each of the hashes listed there generally corresponds to a given thing thats been added
nunofmn has joined #ipfs
nunofmn has quit [Client Quit]
<francis[m]>
but, not necessarily by myself... because i have a long list of output from pin ls
nunofmn has joined #ipfs
<francis[m]>
and i only added 1 file myself. and, thats the one im looking for
nunofmn has quit [Client Quit]
<francis[m]>
i might have the concepts complete wrong here
<whyrusleeping>
francis[m]: ah, `ipfs pin ls --type=recursive`
espadrine has quit [Quit: Konversation terminated!]
<francis[m]>
recursive means, added by me?
espadrine has joined #ipfs
<whyrusleeping>
recursive means 'only show me things that have a recursive pin'
<whyrusleeping>
the `ipfs pin ls` prints 'all' pinned objects by default
<whyrusleeping>
which basically shows you every single block youve added
<whyrusleeping>
(each file consists of multiple blocks, and it was showing you each of those)
<francis[m]>
is there any way to find my way back to the file i added?
<francis[m]>
instead of the blocks making up the file
<whyrusleeping>
currently, not really.
<whyrusleeping>
since we don't track all the 'ipfs add' calls people make
<whyrusleeping>
we want to do this, but finding the right UX for it has proved tricky
<francis[m]>
so, how would i refer to it..
<francis[m]>
say its an mp3, how would i refer to it so that i can play it
<whyrusleeping>
by its hash
<francis[m]>
as an example
<francis[m]>
but... which one?
<whyrusleeping>
the one that you get when you add it
<francis[m]>
i think a hash=bloack now
<francis[m]>
ah, later on, you are not able to retrieve the hash?
charley has quit [Remote host closed the connection]
<whyrusleeping>
right now, unless you wrote down the hash, you have to guess which thing is which from the pin ls list
<whyrusleeping>
or you can run 'ipfs add' again
<francis[m]>
if that is so, i think im not getting it at all... which is more than probable
<whyrusleeping>
which won't take up any extra space
<francis[m]>
thanks whyrusleeping
* francis[m]
will sleep on it
<crankylinuxuser>
Hmm.. Could it be possible to include a .ipfsinfo file with fields that provide a friendly and descriptive "what is this PIN"?
<whyrusleeping>
crankylinuxuser: where would that file live?
<tomatopeel>
whyrusleeping: -a tries to update built stuff even in sys go paths, so it requires root... I guess it doesn't matter, justdoit kinda thing?
<crankylinuxuser>
It could live in the root ipfs hash when a user makes a share.. Nevermind. Just saw the problem, of that being a subhash
<whyrusleeping>
tomatopeel: uhm... i think you can probably actually leave the -a off. I'm pretty sure that if you add different flags, it will rebuild things as needed
<whyrusleeping>
crankylinuxuser: one thought was to just add an append only log file to $IPFS_PATH/log that listed each add
<tomatopeel>
roger, ty
<whyrusleeping>
but then that would grow indefinitely
<crankylinuxuser>
If you did a KVP with a text file with the config, you could add and delete as people added/pinned and unpinned
charley has joined #ipfs
Encrypt has joined #ipfs
<crankylinuxuser>
It would only be local to the machine, but an API call could be crafted to request downloading the KVP file... Still feels inelegant though
<whyrusleeping>
yeah
Monokles has quit [Remote host closed the connection]
<whyrusleeping>
my best idea so far was to somehow timestamp adds into the 'ipfs files' namespace
<whyrusleeping>
so you could do 'ipfs files ls /added' to see everything you added
maxlath has joined #ipfs
atrapado_ has joined #ipfs
charley has quit [Ping timeout: 246 seconds]
fredthomsen has joined #ipfs
baker has joined #ipfs
baker has left #ipfs [#ipfs]
charley has joined #ipfs
<Kubuxu>
whyrusleeping: sorry about sprint call, I tool a nap 2 hours before it and woke up now. At least I am able to think now as it isn't as hot.
<whyrusleeping>
Kubuxu: haha, i definitely sympathize with things being too hot to work
charley has quit [Ping timeout: 258 seconds]
<Kubuxu>
this also gives me stupid idea of going nocturnal :P
Hasperov has quit [Ping timeout: 240 seconds]
SatanicZod has joined #ipfs
nunofmn has joined #ipfs
Monokles has joined #ipfs
Monokles has quit [Remote host closed the connection]
charley has joined #ipfs
Hasperov has joined #ipfs
rudolph has joined #ipfs
charley has quit [Ping timeout: 240 seconds]
<whyrusleeping>
thats basically what juans been doing
maxlath has quit [Ping timeout: 255 seconds]
realisation has joined #ipfs
<tomatopeel>
whyrusleeping: is there a way to pass -gcflags="-N -l" to gx? Just want to make sure that this go-ipfs-cmds package is certainly being installed with those flags
<tomatopeel>
I still need to try that gx uw thing you mentioned though actually
rendar has quit [Quit: std::lower_bound + std::less_equal *works* with a vector without duplicates!]
<whyrusleeping>
you likely won't be able to build ipfs if you do the gx-go uw, some upstream dependencies are broken i think
<tomatopeel>
lol
<tomatopeel>
yeah true
<tomatopeel>
whyrusleeping: is rw the command to re-write the stuff back to gx lang?
<voker57>
error has been present for several weeks
miles has joined #ipfs
<whyrusleeping>
voker57: did you accidentally mess with the installed gx deps?
<whyrusleeping>
oh, some stuff is installed in vendor
<voker57>
whyrusleeping: mess?
<whyrusleeping>
voker57: `rm -rf vendor`
<voker57>
thx that worked
rudolph has joined #ipfs
<voker57>
but what happened and why?
<Kubuxu>
tomatopeel: if you are building go-ipfs then `GOFLAGS='-gcflags="-N -l"'`
<whyrusleeping>
voker57: you maybe ran `gx install` at one point without having `gx-go`? or ran `gx install --local`
<tomatopeel>
Ah just set the env var and compiler will respect it..? Nice...
<whyrusleeping>
tomatopeel: that env var works with `make install`
<tomatopeel>
whyrusleeping: and surely anything else that calls the go compilation tools, including gx right?
<tomatopeel>
as long as called from the env with that var?
<whyrusleeping>
tomatopeel: i'm not sure
<tomatopeel>
maybe the environment would be lost though...
rudolph has quit [Ping timeout: 246 seconds]
ligi has joined #ipfs
ligi has joined #ipfs
ligi has quit [Changing host]
<tomatopeel>
whyrusleeping: sorry to bother you so much but... so the bug is in github.com/ipfs/go-ipfs-cmds - this package needs refactoring, so I just want to refactor some stuff and submit a PR. How do I approach this? Because the repo in my $GOPATH/src/gx/... doesn't have any .git stuff, and if I `go get` it it fails to get got (lol) presumably because this package has been written to only be pulled by gx?
<tomatopeel>
or maybe it's _because_ its imports are all borked that `go get` isn't working?
<whyrusleeping>
tomatopeel: you can do `gx-go rewrite --undo go-ipfs-cmds` to make only those paths go back to github paths
<whyrusleeping>
that *should* work
seagreen has quit [Quit: WeeChat 1.7.1]
<whyrusleeping>
oh, hrm. that package is committed with paths being kinda wonky
<whyrusleeping>
thats less than ideal
<tomatopeel>
whyrusleeping: yeah the go get doesn't work heh
gmoro has joined #ipfs
Fade has quit [Ping timeout: 260 seconds]
<whyrusleeping>
tomatopeel: ah, here we go
<whyrusleeping>
'gx-go rewrite --undo go-ipfs-cmds' then 'go get github.com/ipfs/go-ipfs-cmds' (that will fail)
<whyrusleeping>
then cd $GOPATH/src/github.com/ipfs/go-ipfs-cmds && gx-go rw
<whyrusleeping>
we've got a weird circular dependency things going on, cc keks[m]
rudolph has joined #ipfs
<tomatopeel>
it's just that the imports aren't named properly
<tomatopeel>
(I think)
detran has quit [Read error: Connection reset by peer]
<tomatopeel>
though actually what would go build github.com/ipfs/go-ipfs-cmds even try to build, because there is no package called go-ipfs-cmds, there are those packages cli and http, and then in the root the package seems to be called cmds
<tomatopeel>
maybe all those files ought to go in a dir called cmds
<tomatopeel>
fuck knows
miles has quit [Quit: Page closed]
seagreen has joined #ipfs
Hasperov has quit [Ping timeout: 240 seconds]
detran has joined #ipfs
nunofmn has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
nunofmn has joined #ipfs
nunofmn has quit [Client Quit]
rudolph has quit [Ping timeout: 240 seconds]
nunofmn has joined #ipfs
Encrypt has quit [Quit: Quit]
nunofmn has quit [Client Quit]
nunofmn has joined #ipfs
nunofmn has quit [Client Quit]
nunofmn has joined #ipfs
nunofmn has quit [Client Quit]
<whyrusleeping>
yeah, thats one thing that bothers me about go
nunofmn has joined #ipfs
nunofmn has quit [Client Quit]
<whyrusleeping>
theres this assumption that the package name equals the directory name
<whyrusleeping>
but in reality you can name the package whatever you like
<whyrusleeping>
and we generally name all our imports anyways
nunofmn has joined #ipfs
Fade has joined #ipfs
nunofmn has quit [Client Quit]
nunofmn has joined #ipfs
<tomatopeel>
whyrusleeping: do you know if there was a good reason why this refactor has all this oldcmds/legacy shit? ( cc keks[m] )
<tomatopeel>
this is what's causing the circular deps stuff
nunofmn has quit [Client Quit]
<tomatopeel>
obvious solution would have been to just do a clean refactor...
<whyrusleeping>
tomatopeel: i don't, no
nunofmn has joined #ipfs
nunofmn has quit [Client Quit]
<tomatopeel>
I guess it would make sense for iteratively dev and testing this change
<tomatopeel>
maybe it's just unfinished...
<whyrusleeping>
oh, yeah
nunofmn has joined #ipfs
<whyrusleeping>
we decided against doing the refactor all in one go
nunofmn has quit [Client Quit]
<whyrusleeping>
otherwise we would be forced to rewrite every single command
<whyrusleeping>
all at once
<whyrusleeping>
which would be very unpleasant
<tomatopeel>
lol...
nunofmn has joined #ipfs
jetpac has joined #ipfs
nunofmn has quit [Client Quit]
<whyrusleeping>
so theres a bit of code that translates the old commands into new ones
<whyrusleeping>
so we can gradually rewrite things as we go
<whyrusleeping>
less chances of breaking things
<tomatopeel>
I see
<tomatopeel>
what also scares me is that the branch is so broken but doesn't throw errors when you run it
<whyrusleeping>
go ahead and report all the problems you encounter on that PR
<Kubuxu>
tomatopeel: no it is feature of go-ipfs's Makefile
<whyrusleeping>
(^ referring to the environment variable i think)
nunofmn has joined #ipfs
<tomatopeel>
yeah I know lol
nunofmn has quit [Client Quit]
SatanicZod has quit [Ping timeout: 260 seconds]
nunofmn has joined #ipfs
robattila256 has joined #ipfs
tantalum has left #ipfs [#ipfs]
sirdancealot has quit [Ping timeout: 240 seconds]
ligi has quit [Quit: leaving]
Hasperov has joined #ipfs
pat36 has quit []
Hasperov has left #ipfs [#ipfs]
achip has joined #ipfs
brodo has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
maxlath has joined #ipfs
realisation has quit [Read error: Connection reset by peer]
xelra has joined #ipfs
maxlath has quit [Client Quit]
brodo has joined #ipfs
charley has joined #ipfs
jaboja has quit [Ping timeout: 246 seconds]
robattila256 has quit [Quit: WeeChat 1.8]
joocain2 has quit [Remote host closed the connection]
joocain2 has joined #ipfs
<tomatopeel>
hmmm making a little progress... found and replaced all gx refs to these go-ipfs-cmds and go-ipfs-cmdkit repos to github refs... it runs again now
rudolph has joined #ipfs
ilyaigpetrov has quit [Quit: Connection closed for inactivity]
Miezel_ has quit [Quit: This computer has gone to sleep]
ashark has quit [Ping timeout: 268 seconds]
mildred1 has quit [Ping timeout: 246 seconds]
atrapado_ has quit [Quit: Leaving]
seagreen has quit [Quit: WeeChat 1.7.1]
brodo has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
aceluck has joined #ipfs
Miezel_ has joined #ipfs
Miezel_ has quit [Client Quit]
arpu has quit [Ping timeout: 246 seconds]
Miezel has joined #ipfs
galois_d_ has quit [Remote host closed the connection]
<keks[m]>
tomatopeel: would love to chat about this tomorrow - will you be here in say - 12h?
galois_dmz has joined #ipfs
<keks[m]>
also this counts as an external dependency so it should be a gx import
<keks[m]>
if you want to make them github imports, the easiest way is -- gx-go rewrite --undo
rudolph has quit [Ping timeout: 240 seconds]
akemot has left #ipfs ["Leaving"]
Caterpillar has quit [Quit: You were not made to live as brutes, but to follow virtue and knowledge.]
galois_dmz has quit [Remote host closed the connection]
galois_dmz has joined #ipfs
webdev007 has joined #ipfs
Akaibu has joined #ipfs
espadrine has quit [Ping timeout: 260 seconds]
Monokles has joined #ipfs
<tomatopeel>
keks[m]: 12h is like midday UTC for me... Hmmm
<tomatopeel>
maybe - certainly in about 14-ish hours from now :D
chris613 has joined #ipfs
<keks[m]>
Yeah that's great too
<tomatopeel>
keks[m]: what region/timezone are you?
<tomatopeel>
and I take it you don't have time to chat about this now? heh
<tomatopeel>
oh I see you're looking at using text/templtae
arpu has joined #ipfs
<tomatopeel>
s/ltae/late
Jesin has joined #ipfs
<tomatopeel>
didn't realise that before heh but yeah those fields are all empty because all the stuff is empty in the cmd if it's an OldCommand... haven't looked at the behaviour for a new one yet, I should... presumably the code needs to call into the OldSubcommand, e.g. pin, and call into _its_ subcommands to retrieve those helptext snippets to add to the arg/opt help of the parent (e.g. pin) command...
<tomatopeel>
I'm sure you're already aware, but just to let you know where I'm up to. But yeah, would be cool to chat about it tomorrow, I just raised a github issue which might be a better place to track stuff https://github.com/ipfs/go-ipfs-cmds/issues/15
shizy has quit [Ping timeout: 246 seconds]
arpu has quit [Remote host closed the connection]
dimitarvp has quit [Ping timeout: 255 seconds]
athan has quit [Ping timeout: 260 seconds]
arpu has joined #ipfs
rcat has quit [Ping timeout: 240 seconds]
charley has quit [Remote host closed the connection]
rcat has joined #ipfs
cxl000 has quit [Quit: Leaving]
arpu has quit [Ping timeout: 268 seconds]
charley has joined #ipfs
charley has quit [Read error: Connection reset by peer]
nunofmn has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
arpu has joined #ipfs
charley has joined #ipfs
leeola has quit [Quit: Connection closed for inactivity]