22:22 <wmnnd> Hey everyone. I was thinking about implementing some missing Regexp features with xregexp (like elia suggested might be a way to examine).

22:22 <elia> awesome

22:22 <wmnnd> But first I wanted to hear your opinion on it whether that is actually a good idea and whether you would like to have that in Opal or not.

22:23 <wmnnd> Especially considering that it would require a third-party library (even though it's MIT licensed)

22:24 <elia> meh` adambeynon ^^^ also ryanstout Zackio

22:24 <ryanstout> wmnnd: I haven’t bee following, what features are missing?

22:30 <wmnnd_> ryanstout: Two rather important things: 1) Javascript regexps don't support the /x flag for ignoring whitespace and allowing comments 2) They also doesn't support named matches

22:30 <wmnnd_> ryanstout: http://www.ruby-doc.org/core-1.9.3/Regexp.html#class-Regexp-label-Free-Spacing+Mode+and+Comments

22:30 <ryanstout> wmnnd_: interesting. I don’t use /x, but I have used named matches

22:31 <ryanstout> wmnnd_: would it add a lot of code to the runtime to make it compatible?

22:32 <wmnnd_> ryanstout: The XRegExp code is about 4 KB minified and gzipped.

22:32 <ryanstout> wmnnd_: cool

22:36 <wmnnd_> What's also interesting about xregexp is that it uses regular JavaScript RegExp objects, so there should be no compatibility issues.

22:46 <wmnnd_> So right now, I'm not quite sure how to tacke it. Should I do it for 0.6.2 or the current master branch? Where should the additional JS code be included, where should the license be noted. Do I have to write tests for the new features?

23:36 <meh`> wmnnd_, personally, I wanted to add XRegExp since the beginning of Opal

23:36 <meh`> wmnnd_, so go for it

23:36 <meh`> and go for master

23:37 <meh`> and you do not have to write tests

23:37 <meh`> just tag the failing regexp tests as passing

23:37 <meh`> you could put xregexp.js inside opal/corelib

23:38 <meh`> and require it from regexp.rb