<zyp>
side note; I don't really understand the point of the «Short-circuit for different part count.» in the comparison function
<zyp>
I mean, I'm new to this, but it seems really nonintuitive
<zyp>
since effectively what it does is sorting all strings by how many parts (i.e. groups of digits and non-digits) they contain, and then alphabetically/numerically
<mwk>
well, without the short circuit, it would blow up if a is longer than b
<zyp>
e.g. these four strings will sort in this order: foo, foo.bar, global_clk, bar123, foo.baz[0]
<mwk>
since the later loop assumes the parts lists are of equal length
<mwk>
no
<mwk>
hm
<mwk>
or wait
<mwk>
how does that work...
<mwk>
okay, yes
<mwk>
it... may not exactly be optimal, but that's how it works
<zyp>
the next loop should do i < min(parts_a.size(), parts_b.size()), and if the loop ends without returning, it makes sense to sort the shorter first
peepsalot has joined ##openfpga
<mwk>
right
futarisIRCcloud has joined ##openfpga
<zyp>
I don't mind submitting another PR for that if you'd like, I figure it's a minor thing that either can get fixed now or will get forgotten
<mwk>
merged
<zyp>
nice
<mwk>
zyp: yeah, if you want to
<zyp>
done
Degi has quit [Ping timeout: 255 seconds]
Degi has joined ##openfpga
gregdavill has quit [Ping timeout: 240 seconds]
ZipCPU has joined ##openfpga
gregdavill has joined ##openfpga
mumptai_ has joined ##openfpga
mumptai has quit [Ping timeout: 260 seconds]
Bike has quit [Quit: Lost terminal]
OmniMancer has joined ##openfpga
____ has joined ##openfpga
rohitksingh has joined ##openfpga
gregdavill has quit [Quit: Leaving]
m4ssi has joined ##openfpga
emeb_mac has quit [Quit: Leaving.]
hackkitten has quit [Read error: Connection reset by peer]
hackkitten has joined ##openfpga
Asu has joined ##openfpga
mumptai_ has quit [Remote host closed the connection]
Bob_Dole has joined ##openfpga
ZipCPU has quit [Remote host closed the connection]
ZipCPU has joined ##openfpga
ZipCPU has quit [Remote host closed the connection]
ZipCPU has joined ##openfpga
ZipCPU has quit [Remote host closed the connection]
ZipCPU has joined ##openfpga
ZipCPU has quit [Remote host closed the connection]