08:29 <_florent_> xobs: just for info: https://github.com/enjoy-digital/litex/commit/26fe45fce19bb670ac22c6d38d555be33d8ffed8#commitcomment-36768896, happy to discuss here if you don't find that convenient for your usecase

08:29 <tpb> Title: cores/uart: rename BridgedUART to UARTEmulator and rework/simplify it… · enjoy-digital/litex@26fe45f · GitHub (at github.com)

08:54 <xobs> _florent_: So far as I know, that works!

08:58 <_florent_> xobs: the uart and uart_xover are now in two different CSR regions, is it an issue? (in the original code both UART were in the same CSR region) (i'm asking regarding mithro's comment: https://github.com/enjoy-digital/litex/commit/2f03d3234e1585da5614d49229e94885444ee9c8#commitcomment-36768925)

08:58 <tpb> Title: cores/uart/UART: add stream interface (phy=None), add connect method … · enjoy-digital/litex@2f03d32 · GitHub (at github.com)

08:58 <xobs> _florent_: ah, yes, that is an issue. The idea of them being in the same CSR region is that it wouldn't shift the CSR table at all, and would be a true drop-in replacement.

08:58 <xobs> Complete with PHY.

09:19 <_florent_> xobs: ok sorry, i didn't catch this requirement. https://github.com/enjoy-digital/litex/commit/23175190d859e6d8fd7303cc78c43cf0e3b51326 adds a simplified UARTCrossover module with both UARTs in the same module as you initially did. I have a preference for crossover vs loopback since for me a loopback would mean connecting uart.source to uart.sink.

09:19 <tpb> Title: cores/uart: add UARTCrossover · enjoy-digital/litex@2317519 · GitHub (at github.com)

09:22 <xobs> Alright, if it ends up with the same API I'm happy with the change. I'll need to update wishbone-tool to use the new register name of `_xover` but that's fine.

09:23 <xobs> Oh. That's what they were called before. Nevermind! Looks good to me.

09:27 <_florent_> Yes it should be in fact similar to your first version. I also reduced tx_fifo_depth/rx_fifo_depth on the crossover UART to minimize resource usage. (we already have buffering on the main uart so no need to have another buffering on the crossover UART).

15:06 <keesj> I find the self.comb += self.uart.connect(self.uart_xover) not very elegand

15:07 <keesj> I find the self.comb += self.uart.connect(self.uart_xover) not very elegant

15:59 <_florent_> keesj: thanks for the feedback, i just change that since connect was only used once in last version of the code: https://github.com/enjoy-digital/litex/commit/4648db0c2ad8087aa61794c44939af32e707dd3a

15:59 <tpb> Title: cores/uart/UARTInterface: remove connect method · enjoy-digital/litex@4648db0 · GitHub (at github.com)

16:12 <keesj> I like that one better

17:27 <somlo> _florent_: just curious, why 32868 (as opposed to, say, 0x8000)? https://github.com/enjoy-digital/litex/blob/master/litex/soc/integration/soc_core.py#L88

17:28 <tpb> Title: litex/soc_core.py at master · enjoy-digital/litex · GitHub (at github.com)

17:28 <somlo> that's 32768, actually

17:31 <_florent_> somlo: yes i tried keeping the same default values

17:36 <somlo> _florent_: I was just wondering about why decimal and not hex -- and screwed up the joke in the process with a typo of my own...

17:42 <_florent_> somlo: i was also wondering what was the best, i could revert to hex

17:53 <somlo> _florent_: weak vote in favor of hex from me, since it's slightly easier to follow given the surrounding context (after getting used to seeing hex everywhere, decimal just looks random) :)

17:53 <somlo> but it can probably wait for the next time you actually have to modify things in that neighborhood, as far as I'm concerned :)

19:52 <somlo> _florent_, bunnie[m]: as of LiteX commit #f818755c, this should work with litesdcard: https://pastebin.com/s4unsyrz

19:52 <tpb> Title: [Diff] diff --git a/litesdcard/firmware/sdcard.c b/litesdcard/firmware/sdcard.c index - Pastebin.com (at pastebin.com)

19:53 <somlo> I'm getting the same results as before (successful "sdclk 10" and "sdinit", hangs during "sdtest 8"), but the values read from the SDCORE_RESPONSE CSR are the same :)

20:07 <_florent_> somlo: thanks, i'll test tomorrow!

20:39 <somlo> _florent: ok, it's now https://github.com/enjoy-digital/litesdcard/pull/6, let me know what you think whenever you get a chance